Composite key support in destination #296
Merged
+125
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
approved these changes
Jun 10, 2025
Contributor
raulb
left a comment
raulb
left a comment
There was a problem hiding this comment.
Only left a naming suggestion. Approving in the meantime anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for writing records to tables with composite keys. Note that this removes the
keysetting in the destination connector. I don't see why we need it, since we require the key to contain structured data, which is a map, and the key in the map represents the column name (the same as in.Payload.After).Also I noticed a flaky test in the logrepl package where a closed channel was closed. Turns out that closing of that channel is not even necessary, no reader relies on that channel being closed, so I just removed that to make it safer.
Quick checks: